linux-mips
[Top] [All Lists]

Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support
From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: Wed, 11 Nov 2009 19:21:13 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, cpufreq@vger.kernel.org, Dave Jones <davej@redhat.com>, yanh@lemote.com, huhb@lemote.com
In-reply-to: <acbb780de66413230fb14272e6ce3bf12f9c24d3.1257923011.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257923011.git.wuzhangjin@gmail.com> <acbb780de66413230fb14272e6ce3bf12f9c24d3.1257923011.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
Hey,

On Wed, Nov 11, 2009 at 03:09:59PM +0800, Wu Zhangjin wrote:
> +     printk(KERN_INFO "cpufreq: Loongson-2F CPU frequency driver.\n");
> +     result = cpufreq_register_driver(&loongson2_cpufreq_driver);
> +
> +     if (!result && !nowait) {
> +             saved_cpu_wait = cpu_wait;
> +             cpu_wait = loongson2_cpu_wait;
> +     }
> +
> +     cpufreq_register_notifier(&loongson2_cpufreq_notifier_block,
> +                               CPUFREQ_TRANSITION_NOTIFIER);

IMO you should register the transition notifier before register_driver(),
else there's a small window where a change may be initiate which is not
notified...

Best,
        Dominik

<Prev in Thread] Current Thread [Next in Thread>