linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Make local arrays with CL_SIZE static __initdata

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] MIPS: Make local arrays with CL_SIZE static __initdata
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 11 Nov 2009 14:44:25 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1257614437-8632-1-git-send-email-anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1257614437-8632-1-git-send-email-anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Sun, Nov 08, 2009 at 02:20:37AM +0900, Atsushi Nemoto wrote:

> Since commit 22242681 ("MIPS: Extend COMMAND_LINE_SIZE"), CL_SIZE is
> 4096 and local array variables with this size will cause an build
> failure with default CONFIG_FRAME_WARN settings.
> 
> Although current users of such array variables are all early bootstrap
> code and might not cause real stack overflow (thread_info corruption),
> it would be safe to declare these arrays static with __initdata.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Applied, thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>