[Top] [All Lists]

Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS

To: Steven Rostedt <>
Subject: Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS
From: Wu Zhangjin <>
Date: Mon, 09 Nov 2009 22:35:20 +0800
Cc: Frederic Weisbecker <>,,, Thomas Gleixner <>, Ralf Baechle <>, Nicholas Mc Guire <>, Richard Sandiford <>, David Daney <>, Adam Nemet <>, Patrik Kluba <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=QNukXmdIEjGLhTEjg/CB3rMDHkyS30iLIB1RFDRiPxM=; b=RA3bCcEhfuRLPV/IqDDx9WDwbdGMvyl1rRwdhL/+wYshqtTtAiS7NmtrOre+un1Jjd GwMIVrqh4i8O3uLVwDjxQwX75Cm+rlGNxYs130vSkVAfhjf9K+4JGgfz2PIZNmrfgW7w +yMu0kwOx962yylkcbMTlW3KHVcScOEHdTxNs=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=YrP1anj1s52MjWaY6mM2NyrKAglHiQESqWyXLsVOXh1liEw+vXetQbvVwkKo5MPtDE eNS6wgFT3rjKsNv4ofI5JH5h8Pca+5J5vm606mxITZ7ChLVXubMMsfZLM6tO6tQzS+Ok srdoAajWuL6sgvulOSZKWEcoIhcfNEh+TeW/c=
In-reply-to: <1257771288.2845.11.camel@frodo>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;
References: <> <> <> <> <> <> <> <> <> <1256550156.5642.148.camel@falcon> <20091102214351.GI4880@nowhere> <> <1257771288.2845.11.camel@frodo>

On Mon, 2009-11-09 at 07:54 -0500, Steven Rostedt wrote:
> Just do it in the Makefile. We can add __arch_notrace, and then in the
> Makefile define it with the arch.
> ifeq ($(ARCH), MIPS)
>       CFLAGS_foo.o = -D__arch_notrace=notrace
> endif
> And we can simply define __arch_notrace in a header:
> #ifndef __arch_notrace
> # define __arch_notrace
> #endif
> I much rather uglify the Makefile than the code. 

Seems can not totally avoid the problem mentioned by Frederic, that is
if there are two many functions in the file, and different platforms
care about different functions ;) 

what about Frederic's __time, just replace that __arch_notrace by
__time_notrace, and only consider the time relative functions currently?
Seems this will really make the stuff simpler.

        Wu Zhangjin

<Prev in Thread] Current Thread [Next in Thread>