linux-mips
[Top] [All Lists]

Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS

To: Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Mon, 09 Nov 2009 20:08:07 +0800
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, Ralf Baechle <ralf@linux-mips.org>, Nicholas Mc Guire <der.herr@hofr.at>, Richard Sandiford <rdsandiford@googlemail.com>, David Daney <ddaney@caviumnetworks.com>, Adam Nemet <anemet@caviumnetworks.com>, Patrik Kluba <kpajko79@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=/dOneUS5w7sOBx3RMIXYja4CZpuYlgCEjbgm5jnk008=; b=qpd8O3BByEz7NZumyqETt3DuVJSYjFBIrnNL6S87ydIWJgZY6Mhk+Uv7dm9gCFgWXi Mmany3xuv99yE0J7AZlGsC3eUed0JucB2lnN9F0pzGTJkzSBg7RZSYsS8W7XZxlITE0K Ope8934b0LVqdYiflmoErbncPqkhOzg3brvgo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=r1sbIxhT14CZNB094+aXIrnyfiuiGVektxBj1WS/1l7RNOp5v04d6vdgxeS7KEoaL4 KXrnSOBELKhJl8NohNbwANqLKSa9VlHAaEdkbC9AcpPe5/jqeXuL7K3hGMY9RAk2rQ00 iPoONBrMkzba74i5w/tQLd7YZ9uy0NNexoZKM=
In-reply-to: <20091109115303.GB5206@nowhere>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <54c417629e91f40b2bbb4e08cda2a4e6527824c0.1256483735.git.wuzhangjin@gmail.com> <29bccff04932e993ecd9f516d8b6dcf84e2ceecf.1256483735.git.wuzhangjin@gmail.com> <72f2270f7b6e01ca7a4cdf4ac8c21778e5d9652f.1256483735.git.wuzhangjin@gmail.com> <cover.1256483735.git.wuzhangjin@gmail.com> <6140dd8f4e1783e5ac30977cf008bb98e4698322.1256483735.git.wuzhangjin@gmail.com> <49b3c441a57f4db423732f81432a3450ccb3240e.1256483735.git.wuzhangjin@gmail.com> <c62985530910251727o23beafcco539870e4b2f84637@mail.gmail.com> <1256550156.5642.148.camel@falcon> <20091102214351.GI4880@nowhere> <1257741072.3451.27.camel@falcon.domain.org> <20091109115303.GB5206@nowhere>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2009-11-09 at 12:53 +0100, Frederic Weisbecker wrote:
> On Mon, Nov 09, 2009 at 12:31:12PM +0800, Wu Zhangjin wrote:
> > I think if we use something like __mips_notrace here, we may get lots of
> > __ARCH_notraces here too, 'Cause some other platforms(at least, as I
> > know, Microblaze will do it too) may also need to add one here, it will
> > become:
> > 
> > __mips_notrace __ARCH1_notrace __ARCH2_notrace .... foo() {...}
> > 
> > A little ugly ;)
> 
> 
> Yeah :)
> I thought Mips would be the only one to do that.
> 
>  
> > and If a new platform need it's __ARCH_notrace, they need to touch the
> > common part of ftrace, more side-effects!
> > 
> > but with __arch_notrace, the archs only need to touch it's own part,
> > Although there is a side-effect as you mentioned above ;)
> >
> > So, what should we do?
> > 
> > Regards,
> >     Wu Zhangjin
> >
> 
> Why not __time ?
> As it's normal that such few functions that are used to read the timecounter
> have fair chances to be __no_trace on archs like MIPS. Interested
> archs would just need to override a default stub __time.
> 

Good pointer, will apply it ;)

Regards,
        Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>