linux-mips
[Top] [All Lists]

Re: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Mon, 9 Nov 2009 03:26:42 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, Ralf Baechle <ralf@linux-mips.org>, Richard Sandiford <rdsandiford@googlemail.com>, Nicholas Mc Guire <der.herr@hofr.at>, David Daney <ddaney@caviumnetworks.com>, Adam Nemet <anemet@caviumnetworks.com>, Patrik Kluba <kpajko79@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=5IU8sezTedkQaFeoU6Cv/SZy+I/ECVx1umRfritjcWM=; b=KcPyYNGBhSitdmRBsst06ID6TR1doskOjQORVAJhGHaq6c+zrfO4782xUnNpam9pWw r+ROOsoCZp4XzVfMiZ7YQ6lsKaRqjOCXbi9PYkkF4aymTz917Kz6RbmTZ443QKHq3nm4 vMSfF02mXnXLrtmJskdjwOLZZYZDn7qa2qrQs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=HgPwcky6KihqZSOYwoDU2YnJaCCeOZjsEvDSZK3nXtxZJe4s3OxF1u23SRkm4/a454 +3g4+tDYqX+CK/fx7nvJAWxfwqEd5OMjtciLmlz8JH31tOLXuRiy4Tem1YwBwnAQZDhs 2tdPsvsSIYnIA+zceqVPb1cZJIyKdDjpnEEho=
In-reply-to: <f746f813531a16bd650f9290787c66cbc0cdc34d.1256569489.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1256569489.git.wuzhangjin@gmail.com> <f746f813531a16bd650f9290787c66cbc0cdc34d.1256569489.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Oct 26, 2009 at 11:13:25PM +0800, Wu Zhangjin wrote:
> This patch add a new section for MIPS to record the block of the hardirq
> handling for function graph tracer(print_graph_irq) via adding the
> __irq_entry annotation to the the entrypoints of the hardirqs(the block
> with irq_enter()...irq_exit()).
> 
> Thanks goes to Steven & Frederic Weisbecker for their feedbacks.
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> +
> +/*
> + * do_IRQ handles all normal device IRQ's (the special
> + * SMP cross-CPU interrupts have their own specific
> + * handlers).
> + */
> +unsigned int __irq_entry do_IRQ(unsigned int irq)
> +{
> +     irq_enter();
> +     __DO_IRQ_SMTC_HOOK(irq);
> +     generic_handle_irq(irq);
> +     irq_exit();
> +
> +     return 1;
> +}



Nano-neat:

Why is it returning a value, it doesn't seem needed (the macro
version didn't)?

Anyway, that looks good to me. I hope the changes from macro
to function calls will be ack by the MIPS maintainers.

Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>


<Prev in Thread] Current Thread [Next in Thread>