linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Make local arrays with CL_SIZE static __initdata

To: dmitri.vorobiev@gmail.com
Subject: Re: [PATCH] MIPS: Make local arrays with CL_SIZE static __initdata
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 08 Nov 2009 20:50:07 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <90edad820911071016v70e6e68bia8f0c3b6f09ceb3c@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1257614437-8632-1-git-send-email-anemo@mba.ocn.ne.jp> <90edad820911071016v70e6e68bia8f0c3b6f09ceb3c@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 7 Nov 2009 20:16:57 +0200, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> 
wrote:
> > --- a/arch/mips/bcm47xx/prom.c
> > +++ b/arch/mips/bcm47xx/prom.c
> > @@ -100,7 +100,7 @@ static __init void prom_init_console(void)
> >
> >  static __init void prom_init_cmdline(void)
> >  {
> > -       char buf[CL_SIZE];
> > +       static char buf[CL_SIZE] __initdata;
> 
> If this is intended for -queue, this patch won't apply, because
> CL_SIZE was recently removed in favor of using CONFIG_CMDLINE_SIZE
> directly.

Oh I missed your CL_SIZE removal patch.  Anyway I want this patch for
2.6.32 since this is regression.

If the CL_SIZE removal patch was merged for 2.6.32 first, I will
update my patch.  Othersize, your patch needs update, but I suppose we
can do it easily.  Of course Ralf can do it too ;)

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>