linux-mips
[Top] [All Lists]

Re: COMMAND_LINE_SIZE and CONFIG_FRAME_WARN

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: COMMAND_LINE_SIZE and CONFIG_FRAME_WARN
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Date: Fri, 6 Nov 2009 18:22:09 +0200
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=YeQAqqaOaKnkNMfC0SaJexwgro96aJYQuuHbPxGXw98=; b=V68LcFI2VzyqCaFf49uOMbBGkAm3Ft9wWFBLVWSejEzvuqCNin3fzffGKtoLwkcivd +b7CyHX4yq9oJUusoZyoOWyVl9nDLDg1WpaD3egvoBx9fZ3DRymGTcyInVnPbsORZ3Ib hBgrGkMzBGK04kOIQTsccqTpNJ6QA5XMtxWHs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=O46i4MdQ3ypgzREBfS7yeKa86OOaMabXJQC8WHWzW5O24vH4X4payrMozTaioq9tGQ +MXQyEbx8wnptqEah02XlFI+mcgVWVVvLRg6XWl1j/PsDcuaBjLcjRTSxhz4WHBuJskX x8mR6kdJq6GEw/0QjArilx6g2tzmHOBCuJUVg=
In-reply-to: <20091107.010839.246840249.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20091107.010839.246840249.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Nov 6, 2009 at 6:08 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Recently COMMAND_LINE_SIZE (CL_SIZE) was extended to 4096 from 512.
> (commit 22242681 "MIPS: Extend COMMAND_LINE_SIZE")
>
> This cause warning if something like buf[CL_SIZE] was declared as a
> local variable, for example in prom_init_cmdline() on some platforms.
>
> And since many Makefiles in arch/mips enables -Werror, this cause
> build failure.
>
> How can we avoid this error?
>
> - do not use local array? (but dynamic allocation cannot be used in
>  such an early stage.  static array?)

Maybe a static array marked with __initdata?

Dmitri

<Prev in Thread] Current Thread [Next in Thread>