Re: [PATCH 2/2] [loongson] fuloong: add RTC_LIB Support

[Wu Zhangjin <wuzhangjin@gmail.com>]

Hi,

On Wed, 2009-11-04 at 17:03 +0100, Arnaud Patard wrote:
> Wu Zhangjin <wuzhangjin@gmail.com> writes:
> Hi,
> 
> > + *  Registration of Cobalt RTC platform device.
> 
> Of Cobalt platform device ? I thought we were on loongson :)
> 

Ooh, I just copied the header ;) will remove it later.

> > + *
> > + *  Copyright (C) 2007  Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> > + *  Copyright (C) 2009  Wu Zhangjin <wuzj@lemote.com>
> > + *
> > + *  This program is free software; you can redistribute it and/or modify
> > + *  it under the terms of the GNU General Public License as published by
> > + *  the Free Software Foundation; either version 2 of the License, or
> > + *  (at your option) any later version.
> > + */
> > +
> > +#include <linux/init.h>
> > +#include <linux/ioport.h>
> > +#include <linux/mc146818rtc.h>
> > +#include <linux/platform_device.h>
> > +
> > +static struct resource rtc_cmos_resource[] = {
> > +   {
> > +           .start  = RTC_PORT(0),
> > +           .end    = RTC_PORT(1),
> > +           .flags  = IORESOURCE_IO,
> > +   },
> > +   {
> > +           .start  = RTC_IRQ,
> > +           .end    = RTC_IRQ,
> > +           .flags  = IORESOURCE_IRQ,
> > +   },
> > +};
> > +
> > +static struct platform_device rtc_cmos_device = {
> > +   .name           = "rtc_cmos",
> > +   .id             = -1,
> > +   .num_resources  = ARRAY_SIZE(rtc_cmos_resource),
> > +   .resource       = rtc_cmos_resource
> > +};
> > +
> > +static __init int rtc_cmos_init(void)
> > +{
> > +   platform_device_register(&rtc_cmos_device);
> > +
> > +   return 0;
> 
> what about return platform_device_register(&rtc_cmos_device); ?
> 
> 

Okay, later.

Regards,
        Wu Zhangjin