linux-mips
[Top] [All Lists]

Re: [PATCH -queue v0 1/6] [loongson] add basic loongson-2f support

To: wuzhangjin@gmail.com
Subject: Re: [PATCH -queue v0 1/6] [loongson] add basic loongson-2f support
From: Arnaud Patard <apatard@mandriva.com>
Date: Wed, 04 Nov 2009 12:36:23 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>, huhb@lemote.com, yanh@lemote.com, Zhang Le <r0bertz@gentoo.org>, Thomas Gleixner <tglx@linutronix.de>, Nicholas Mc Guire <der.herr@hofr.at>, zhangfx@lemote.com, liujl@lemote.com
In-reply-to: <1257332652.8716.5.camel@falcon.domain.org> (Wu Zhangjin's message of "Wed, 04 Nov 2009 19:04:12 +0800")
Organization: Mandriva
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257325319.git.wuzhangjin@gmail.com> <a1bd2470bc465e505281c761adca8c2287d102b3.1257325319.git.wuzhangjin@gmail.com> <m3iqdqtwgk.fsf@anduin.mandriva.com> <1257332652.8716.5.camel@falcon.domain.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux)
Wu Zhangjin <wuzhangjin@gmail.com> writes:

> Hi,
>
> On Wed, 2009-11-04 at 11:28 +0100, Arnaud Patard wrote:
> [...]
>> > +
>> > +config CPU_LOONGSON2F
>> > +  bool "Loongson 2F"
>> > +  depends on SYS_HAS_CPU_LOONGSON2F
>> > +  select CPU_LOONGSON2
>> > +  help
>> > +    The Loongson 2F processor implements the MIPS III instruction set
>> > +    with many extensions.
>> > +
>> > +    Loongson2F have built-in DDR2 and PCIX controller. The PCIX controller
>> > +    have a similar programming interface with FPGA northbridge used in
>> > +    Loongson2E.
>> > +
>> 
>> Small question : Why don't you restrict to 64bit kernels only ? From
>> what I remember from some discussions with ST, trying to use a 32-bit
>> kernel on 2f is a nice way to get troubles. It would be better imho to
>> forbid such a configuration. As a side effect, this will remove all
>> 'defined(CONFIG_64BIT)' parts of your #ifdef tests. 
>> 
>
> It's hard to make such a decision ;) Perhaps some guys want to play with
> the 32bit version.

It's a matter of taste : using 32 bit and getting an more or less broken
machine or using 64bit and getting a working machine. I don't think a
lot of people will choose the first option :)

Arnaud

<Prev in Thread] Current Thread [Next in Thread>