linux-mips
[Top] [All Lists]

Re: [RFC PATCH 1/3] MIPS: Alchemy: extended DB1200 board support.

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [RFC PATCH 1/3] MIPS: Alchemy: extended DB1200 board support.
From: Kevin Hickey <khickey@netlogicmicro.com>
Date: Tue, 03 Nov 2009 09:41:03 -0600
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <1257193305-29996-1-git-send-email-manuel.lauss@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1257193305-29996-1-git-send-email-manuel.lauss@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2009-11-02 at 21:21 +0100, Manuel Lauss wrote:
> Create own directory for DB1200 code and update it with new features.
> 
> - SPI support:
>   - tmp121 temperature sensor
>   - SPI flash on DB1200
> - I2C support
>   - NE1619 sensor
>   - AT24 eeprom
> - I2C/SPI can be selected at boot time via switch S6.8
> - Carddetect IRQs for SD cards.
> - gen_nand based NAND support.
> - hexleds count sleep/wake transitions.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---

The code in this patch all looks good to me.  I don't understand how
much value is added by using the hex LEDs for counting sleep/wake
transitions.  In our internal builds, we use the hex LEDs for displaying
the last interrupt serviced (useful on hangs/crashes and for getting a
general sense of what the hardware is working on), the dots blink on
timer ticks (often every 100 or 1000 depending on the clock) and the
Idle state is shown on LED0.  I don't really have any strong attachment
to those usages, but they've served us well.

Otherwise this looks good to me.  Hope this isn't too late (I saw the
email saying it was queued come in as I typed this one).

=Kevin


<Prev in Thread] Current Thread [Next in Thread>