linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] alchemy: fix warnings in db1x00/pb1000/pb1550 board set

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/2] alchemy: fix warnings in db1x00/pb1000/pb1550 board setup code
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Mon, 2 Nov 2009 12:43:20 +0100
Cc: Florian Fainelli <florian@openwrt.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=3zhy4PTl+VqzfJXPMsuBbS7WFVbrU6XimSyYW9G6r8A=; b=VhnOvkPuvRuoS1EqNB363nHPu2dyw3/8UljcFwPkaKTSLz4Q/KHjvx5LJLqDEc+XMN ETFQN0iUF0MydhHFOhvtUWqC/p0rxbXYnJiZBLCp/7yEkdHv77IOJh709MM/OKDMU+u1 5THKD8WjAeteuYH/kkDaGA9Ugi/KNEn9J1zso=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Zy+34hCOKQmFUoH/PQ3o5HdNthCkErUCbuvRhEPr7i6sp5wxUeAUbItJ35CKNUi7IA S8kN5NJPq/8xoLxbDNtCEalEdOdA0/5Vhvzk5BmWCNVbKWvO2egFhu5h2LkhKN5h6gxi tP3oLg60IEIIuZARh0t7XdvbvbZQGi6AVpyUM=
In-reply-to: <20091102112955.GA2821@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200910181604.11732.florian@openwrt.org> <f861ec6f0910190412i3910246dgcdf6b8b56a8ed5b3@mail.gmail.com> <20091102112955.GA2821@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Nov 2, 2009 at 12:29 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Mon, Oct 19, 2009 at 01:12:15PM +0200, Manuel Lauss wrote:
>
>> I like it, thank you!
>
> Except that it a) does things the comments don't mention and b) doesn't

It does eliminate all the "variable may be unused"-type warnings...


> apply on top of master or -queue ...

It did apply against -queue when Floarian initally sent it.  If he doesn't
resurface in the next few days I'll send an update version.

Manuel

<Prev in Thread] Current Thread [Next in Thread>