linux-mips
[Top] [All Lists]

Re: [PATCH -v1] MIPS: a few of fixups and cleanups for the compressed ke

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH -v1] MIPS: a few of fixups and cleanups for the compressed kernel support
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 29 Oct 2009 09:17:22 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, "Maciej W. Rozycki" <macro@linux-mips.org>
In-reply-to: <1256797212-7794-1-git-send-email-wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256797212-7794-1-git-send-email-wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Wu Zhangjin wrote:
From: Wu Zhangjin <wuzhangjin@gmail.com>

[...]
        .comm .heap,BOOT_HEAP_SIZE,4
        .comm .stack,4096*2,4
+       .set reorder

I feel a little ambivalent about the '.set reorder'.

Since it is at the end of the file, you could omit it. If you think you will add more things around it, you could put a '.set push' at the top and then use '.set pop' here. Or you could leave it as is.

David Daney

<Prev in Thread] Current Thread [Next in Thread>