linux-mips
[Top] [All Lists]

Re: [PATCH -sfr.git] MIPS: zboot: indent the nop instruction in delay sl

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH -sfr.git] MIPS: zboot: indent the nop instruction in delay slot
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 29 Oct 2009 03:12:17 +0000 (GMT)
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, Robert Richter <robert.richter@amd.com>, chenj@lemote.com
In-reply-to: <1256782252-2240-1-git-send-email-wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256782252-2240-1-git-send-email-wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 29 Oct 2009, Wu Zhangjin wrote:

> diff --git a/arch/mips/boot/compressed/head.S 
> b/arch/mips/boot/compressed/head.S
> index e23f25e..29080f4 100644
> --- a/arch/mips/boot/compressed/head.S
> +++ b/arch/mips/boot/compressed/head.S
> @@ -38,7 +38,7 @@ start:
>       PTR_LA  ra, 2f
>       PTR_LA  k0, decompress_kernel
>       jr      k0
> -     nop
> +      nop
>  2:
>       move    a0, s0
>       move    a1, s1
> @@ -46,7 +46,7 @@ start:
>       move    a3, s3
>       PTR_LI  k0, KERNEL_ENTRY
>       jr      k0
> -     nop
> +      nop
>  3:
>       b 3b
>       END(start)

 This piece of code looks unsafe to me.  I'm not sure which tree this is 
against and certainly I don't have a local copy of the file, but based on 
the manual delay slot scheduling this is built with .set noreorder in 
effect and as such the function lacks a delay slot fill for the trailing 
branch (which is also ill-formatted).

  Maciej

<Prev in Thread] Current Thread [Next in Thread>