linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 28 Oct 2009 21:11:29 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, linux-serial@vger.kernel.org, Manuel Lauss <manuel.lauss@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=VGrdOYcZ/Q0o+ABXJtu2yKdMmNVP/WWFLSD7fqlYL1I=; b=pE4sHWqmn//15mBYkWGLod9MSODNIB02sUvvRpKji8iblCj/2QebV3S8Co7GigoF8l 0VUgDtTbv3U6H6yJwWkBKOsJy7ZcZfneifuv2WKcVyLN84eD2F27C0vMyPVyCz1txDds CsDq2KRod0kKC0+rwn/wuLtuaI4enwpPfhGf4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=c9gRoQ0cA1odk33krSO3qE7inlWTPu9z99UIa19UEtRAmCeCMS6NmgiJoDx4FETCtQ VHuaJ21xjuDkaZ7c+UnA62sJzhcvsHEy4ZJt2o8qzbjyUWdTC8WiP4evEljb0txfapic w3i5SKwkT3FNkJcv6iWsdsGqS8fJAgS6YhH4Y=
In-reply-to: <20091028125203.c513883e.akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com> <20091028122430.f7670ae2.akpm@linux-foundation.org> <f861ec6f0910281227t455a6f5cw9e492a9a1fc1b07e@mail.gmail.com> <20091028125203.c513883e.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org


On Wed, Oct 28, 2009 at 8:52 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
On Wed, 28 Oct 2009 20:27:16 +0100
Manuel Lauss <manuel.lauss@googlemail.com> wrote:

> On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton <akpm@linux-foundation.org>wrote:
>
> > On Wed, 28 Oct 2009 20:09:14 +0100
> > Manuel Lauss <manuel.lauss@googlemail.com> wrote:
> >
> > > UART autodetection breaks on the Au1300 but the IP blocks are
> > > identical, at least in the datasheets.
> > >
> > > Pass uart type on to the 8250 driver via platform data, and move
> > > the MSR quirk to another place sind autoconf() is now no longer
> > > called on init.
> > >
> > > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> > > ---
> > > Tested on DB1200 and DB1300.
> > > The mips parts apply on top of Ralf's mips-queue tree.
> > >
> > >  arch/mips/alchemy/common/platform.c |    4 +++-
> > >  drivers/serial/8250.c               |   13 +++++++------
> > >  2 files changed, 10 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/arch/mips/alchemy/common/platform.c
> > b/arch/mips/alchemy/common/platform.c
> > > index 195e5b3..3be14b0 100644
> > > --- a/arch/mips/alchemy/common/platform.c
> > > +++ b/arch/mips/alchemy/common/platform.c
> > > @@ -26,7 +26,9 @@
> > >               .irq            = _irq,                         \
> > >               .regshift       = 2,                            \
> > >               .iotype         = UPIO_AU,                      \
> > > -             .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
> > > +             .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
> > > +                               UPF_FIXED_TYPE,               \
> > > +             .type           = PORT_16550A,                  \
> > >       }
> >
> > The kernel which you patched differs from current mainline here.
>
>
>  I know, that's why I added "The mips parts apply on top of Ralf's
> mips-queue tree" below
> the patch description.

If that's the case then Ralf's mips-queue tree isn't in linux-next :(

> If it makes it easier to apply, I could split this one in a mips and in a
> 8250 patch?

That's a hard call without knowing what's going on in mipsworld.  If
these patches applied to current mainline we could do it all as one
patch and, with suitable acks, slap it into 2.6.32.

The 8250.c hunks from both patches apply against current -git; only the
mips hunk is against Ralfs queue tree (the mips hunk on its own would
probably break something wrt. modem signals which I can't test now anyway)

I'll resend with a new series: 1 patch with the mips part (to Ralf)
and one with the 8250.c part (to you).

 
Are these fixes also appropriate to 2.6.31.x and earlier?  If so,

Not really; patch #1 is necessary to get serial going on a chip not
yet supported in mainline, and patch #2 works around failing uart
autodetection on this new soc.
 
that's another reason to prepare the patches against current mainline
and just trample over the mips devel queue.

Understood.

Thank you!
     Manuel Lauss
<Prev in Thread] Current Thread [Next in Thread>