linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 28 Oct 2009 20:55:14 +0100
Cc: Andrew Morton <akpm@linux-foundation.org>, Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, linux-serial@vger.kernel.org, Manuel Lauss <manuel.lauss@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=ZM1oBuZ+dh3iw4sP8Q0cKjgY26ja2H/5zZ107TK8+a8=; b=iKXCW2vq2t6jBmgFyH1GY0kegKr69nTQ2eL+mqEgFHXlKnX0/TRPeuFNE+Y2d46Geg px75QDQ0VSxd/Q9puv+6nWm4mVu0NL+I69aoFUszWWvwVjYZA/CBpAvM9aD4Cg8LJeIS ookrsy/LZ1/tT6beQz5RzxJXSPTjuTvzM4CI4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=P5RdiAr/ZySBQM6EVtaCxAMqdGmHTgYnulXUJPoIKB/21/yAv2fAOL6ZDuRSA2z2+E BNZirWFcLBNlllSZXcRn4Dv/XQChozqnQ4rwgsyb6hFH4amO6D4k9bLP+UIYQUNo/FSb 6gdeSHdfrDqCMcPIIxn5cd2QsRw70IddYetyM=
In-reply-to: <4AE89D2E.4060704@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com> <4AE89D2E.4060704@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org


On Wed, Oct 28, 2009 at 8:36 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
Hello.


Manuel Lauss wrote:

UART autodetection breaks on the Au1300 but the IP blocks are
identical, at least in the datasheets.

Pass uart type on to the 8250 driver via platform data, and move
the MSR quirk to another place sind autoconf() is now no longer

  s/sind autoconf/since autoconfig/

Yeah, I suck at writing descriptions. Will fix.


called on init.

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
Tested on DB1200 and DB1300.
The mips parts apply on top of Ralf's mips-queue tree.

 arch/mips/alchemy/common/platform.c |    4 +++-
 drivers/serial/8250.c               |   13 +++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common/platform.c
index 195e5b3..3be14b0 100644
--- a/arch/mips/alchemy/common/platform.c
+++ b/arch/mips/alchemy/common/platform.c
@@ -26,7 +26,9 @@
               .irq            = _irq,                         \
               .regshift       = 2,                            \
               .iotype         = UPIO_AU,                      \
-               .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
+               .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
+                                 UPF_FIXED_TYPE,               \

  Good to know this has been implemented.

David Daney implemented this recently for his Octeon port, it's a very handy feature for sure.

Thank you !
      Manuel Lauss
<Prev in Thread] Current Thread [Next in Thread>