linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 28 Oct 2009 20:27:16 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, linux-serial@vger.kernel.org, Manuel Lauss <manuel.lauss@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=zPF7s1OPVweiSZeic6McA93TdK06fIl0qn5M7bxWd6o=; b=jrtws4S2poiYM9UTaXh+eSKvBb/3AYZRub+ukLtwLAqkvo9QvaEmiraIiBW7Ire1MB 8okkv5ySfHdll5WEPtKrD2w4OuPvume30rufGNtjEDYQIcMny7An3uInBY5tPzzri7dC w9UfoiIi+kmnEUCp6Rd6+BkX3BJkU1Fn69Y6k=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=TBKf9HGtxOphY8AB9EtLwVs0vccp8zK94Isa0EztTb/9cWWRNYyYZcLFmC+hY9RLrg wyyEM0ziUOE334qOuHJ4Rr8zpGLwUxJuxesJi3SxP2wYWLD6zPV4BteI5LUB4sXyDS6A 49H/E5iY3Pnwj1gNg6GJvheRdYLvyFbsEIFBo=
In-reply-to: <20091028122430.f7670ae2.akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com> <20091028122430.f7670ae2.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org


On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
On Wed, 28 Oct 2009 20:09:14 +0100
Manuel Lauss <manuel.lauss@googlemail.com> wrote:

> UART autodetection breaks on the Au1300 but the IP blocks are
> identical, at least in the datasheets.
>
> Pass uart type on to the 8250 driver via platform data, and move
> the MSR quirk to another place sind autoconf() is now no longer
> called on init.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> Tested on DB1200 and DB1300.
> The mips parts apply on top of Ralf's mips-queue tree.
>
>  arch/mips/alchemy/common/platform.c |    4 +++-
>  drivers/serial/8250.c               |   13 +++++++------
>  2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common/platform.c
> index 195e5b3..3be14b0 100644
> --- a/arch/mips/alchemy/common/platform.c
> +++ b/arch/mips/alchemy/common/platform.c
> @@ -26,7 +26,9 @@
>               .irq            = _irq,                         \
>               .regshift       = 2,                            \
>               .iotype         = UPIO_AU,                      \
> -             .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
> +             .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
> +                               UPF_FIXED_TYPE,               \
> +             .type           = PORT_16550A,                  \
>       }

The kernel which you patched differs from current mainline here. 
 
 I know, that's why I added "The mips parts apply on top of Ralf's mips-queue tree" below
the patch description.
If it makes it easier to apply, I could split this one in a mips and in a 8250 patch?

Thank you!
     Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>