linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 28 Oct 2009 12:24:30 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux-MIPS <linux-mips@linux-mips.org>, linux-serial@vger.kernel.org, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 28 Oct 2009 20:09:14 +0100
Manuel Lauss <manuel.lauss@googlemail.com> wrote:

> UART autodetection breaks on the Au1300 but the IP blocks are
> identical, at least in the datasheets.
> 
> Pass uart type on to the 8250 driver via platform data, and move
> the MSR quirk to another place sind autoconf() is now no longer
> called on init.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> Tested on DB1200 and DB1300.
> The mips parts apply on top of Ralf's mips-queue tree.
> 
>  arch/mips/alchemy/common/platform.c |    4 +++-
>  drivers/serial/8250.c               |   13 +++++++------
>  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/mips/alchemy/common/platform.c 
> b/arch/mips/alchemy/common/platform.c
> index 195e5b3..3be14b0 100644
> --- a/arch/mips/alchemy/common/platform.c
> +++ b/arch/mips/alchemy/common/platform.c
> @@ -26,7 +26,9 @@
>               .irq            = _irq,                         \
>               .regshift       = 2,                            \
>               .iotype         = UPIO_AU,                      \
> -             .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
> +             .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
> +                               UPF_FIXED_TYPE,               \
> +             .type           = PORT_16550A,                  \
>       }

The kernel which you patched differs from current mainline here.

<Prev in Thread] Current Thread [Next in Thread>