| To: | Linus Walleij <linus.ml.walleij@gmail.com> |
|---|---|
| Subject: | Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic |
| From: | David Daney <ddaney@caviumnetworks.com> |
| Date: | Tue, 20 Oct 2009 15:44:12 -0700 |
| Cc: | Thomas Gleixner <tglx@linutronix.de>, Linus Walleij <linus.walleij@stericsson.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, Mikael Pettersson <mikpe@it.uu.se>, Ralf Baechle <ralf@linux-mips.org> |
| In-reply-to: | <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1255819715-19763-1-git-send-email-linus.walleij@stericsson.com> <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain> <4ADE3225.5050001@caviumnetworks.com> <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Linus Walleij wrote: 2009/10/20 David Daney <ddaney@caviumnetworks.com>:Please do not make that functions inline. They are too large and there is no benefit of inlining them.If that is the case, then perhaps they should not be defined in a header file.Of course not. There are apropriate places to put them, but as stated I think the use as it is today warrants having them inlined. I wasn't trying to imply that they shouldn't be inlined, only that if you choose (as you did) to define them in a header file, that they *should* be inline. David Daney |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic v2, Linus Walleij |
|---|---|
| Next by Date: | Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic v2, Mikael Pettersson |
| Previous by Thread: | Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic, Linus Walleij |
| Next by Thread: | [PATCH 1/2] alchemy: fix warnings in db1x00/pb1000/pb1550 board setup code, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |