linux-mips
[Top] [All Lists]

Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic
From: Linus Walleij <linus.ml.walleij@gmail.com>
Date: Wed, 21 Oct 2009 00:16:56 +0200
Cc: Thomas Gleixner <tglx@linutronix.de>, Linus Walleij <linus.walleij@stericsson.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, Mikael Pettersson <mikpe@it.uu.se>, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=XaUSnduxeDoXgBmT+YclK1/ijvTkXjGQnQZ/74sNJe4=; b=N6BZGohFA2cLRTdwMuW2C7NZ+gm+bWEJhSHk82bMhPqgQqelPeDbEJkeKHch3OJcGQ CaM1NSSNJPeAq2v+KkQNkZH57vh5IOEttPSCkKKh+1oiaqxmt/JojzcdxsEb1q89M8NG 6MrmItb3O1SD6xILcEiLkVG0fMU5khenB+WKE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=BWyLvb2x+26qEHNXClkdv2Yz9YaXFdN1fVm+lSqCGaLRYIW8XaZ2dxVjM5L44X6d0a yU3TiZkgst7exiiBH2VQvTkPJiLD5+hUcxKbIqmTPzr1bnBzBBWiT9kU776DWxOfTmdB fYmINKyPOQOw9YtWGg1M87o5BvUMv90QR5BjI=
In-reply-to: <4ADE3225.5050001@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255819715-19763-1-git-send-email-linus.walleij@stericsson.com> <alpine.LFD.2.00.0910200454300.2863@localhost.localdomain> <4ADE3225.5050001@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
2009/10/20 David Daney <ddaney@caviumnetworks.com>:

>> Please do not make that functions inline. They are too large and there
>> is no benefit of inlining them.
>
> If that is the case, then perhaps they should not be defined in a header
> file.

Of course not. There are apropriate places to put them, but as stated
I think the use as it is today warrants having them inlined.

Linus Walleij

<Prev in Thread] Current Thread [Next in Thread>