[Top] [All Lists]

Re: [PATCH 1/2] tracing: convert trace_clock_local() as weak function

To: Wu Zhangjin <>
Subject: Re: [PATCH 1/2] tracing: convert trace_clock_local() as weak function
From: Américo Wang <>
Date: Fri, 16 Oct 2009 19:52:14 +0800
Cc:, linux-mips <>, Ralf Baechle <>, Thomas Gleixner <>, Steven Rostedt <>, Ingo Molnar <>, Manuel Lauss <>, Atsushi Nemoto <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=r04+XZ5pc95a6TBKCpo6MfnbvRuHr3AOq7xkJtaXFD4=; b=KHD6XAfyzL2OrsOWW3vwTZ4g6njBFRVmXpsu3QRqYO40tbRcEnK8GyBfJG2xWOEWY6 SUzpeqGLPMTZoKJtEQER2unXLumi9r5NIMeecuQFflRCahkFqucPtoMfaBoj4HDIKiQt sVfyARsP5JtnosLbfJ62t2B8dLJaoO2RGcF6o=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=wYAQ38mZ1wLmu/bqqZsx5DUSFw9waVKwdgbt1hsy/tebUWr2Ga+2p5PbR973XGjs63 zavOQYqtA13l6wgzPekNQ648tPF/OZQqyCjTDjZadxI8xOZec5suAQCGzACMrzUcf6db Jz8xykb3nGaOiOazf7eMPJpXI8jsg09hygCC0=
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Oct 16, 2009 at 07:38:24PM +0800, Wu Zhangjin wrote:
>trace_clock_local() is based on the arch-specific sched_clock(), in X86,
>it is tsc(64bit) based, which can give very high precision(about 1ns
>with 1GHz). but in MIPS, the sched_clock() is jiffies based, which can
>give only 10ms precison with 1000 HZ. which is not enough for tracing,
>especially for Real Time system.
>so, we need to implement a MIPS specific sched_clock() to get higher
>precision. There is a tsc like clock counter register in MIPS, whose
>frequency is half of the processor, so, if the cpu frequency is 800MHz,
>the time precision reaches 2.5ns, which is very good for tracing, even
>for Real Time system.
>but 'Cause it is only 32bit long, which will rollover quickly, so, such
>a sched_clock() will bring with extra load, which is not good for the
>whole system. so, we only need to implement a arch-specific
>trace_clock_local() for tracing. as a preparation, we convert it as a
>weak function.
>The MIPS specific trace_clock_local() is coming in the next patch.
>Signed-off-by: Wu Zhangjin <>
> kernel/trace/trace_clock.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c
>index 20c5f92..a04dc18 100644
>--- a/kernel/trace/trace_clock.c
>+++ b/kernel/trace/trace_clock.c
>@@ -26,7 +26,7 @@
>  * Useful for tracing that does not cross to other CPUs nor
>  * does it go through idle events.
>  */
>-u64 notrace trace_clock_local(void)
>+u64 __attribute__((weak)) notrace trace_clock_local(void)

We have __weak.

> {
>       unsigned long flags;
>       u64 clock;
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to
>More majordomo info at
>Please read the FAQ at

Live like a child, think like the god.

<Prev in Thread] Current Thread [Next in Thread>