| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: BUG? linux-mips flush_dcache_page |
| From: | Minchan Kim <minchan.kim@gmail.com> |
| Date: | Fri, 16 Oct 2009 19:43:20 +0900 |
| Cc: | Atsushi Nemoto <anemo@mba.ocn.ne.jp>, lkml <linux-kernel@vger.kernel.org>, linux-mips <linux-mips@linux-mips.org>, Chungki woo <chungki.woo@gmail.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=D72b1dgqmtS+vGA2HW/TAWOB7JJV43GsEFTqXjsCJzg=; b=bLUu1L9EEVTZ+1Zj5djjPqZ9xIT60VNiNYYfHNDuhA4foue7hg9JYqeZmrVRY+grVO srJ2w1tal7TMwXXP5ODlcbdcpaifx1A4TLCnvGVn6TwUciUubfEAen3oHnJesmPW+1O3 pGDTHHl+5KKeixhSCAmkFwn2Tt3yHxPEaB4b8= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=EyK5gybDF6cNb8G3j5JFjOtOycww8HZHPA/DQeAj5Z5QUfKJuZ/NycQBf9Nd5QOiS0 uSSICkUUao3uFU4VVuiYm3yqErw7Xti0+PJ6ZkAFCS7mJuHsDEcP9rEpk24yCfo0u4iM PwxLdNFZSRjlX6v2yME8aAkQRHojzX9V03c8A= |
| In-reply-to: | <20091016092418.GA3686@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20091016141719.de606482.minchan.kim@barrios-desktop> <20091016092418.GA3686@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Fri, Oct 16, 2009 at 6:24 PM, Ralf Baechle <ralf@linux-mips.org> wrote: > On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote: > >> Many code of kernel fs usually allocate high page and flush. >> But flush_dcache_page of mips checks PageHighMem to avoid flush >> so that data consistency is broken, I think. > > What processor and cache configuration? Chungki. Could you anwer this question ? >> I found it's by you and Atsushi-san on 585fa724. >> Why do we need the check? >> Could you elaborte please? > > The if statement exists because __flush_dcache_page would crash if a page > is not mapped. This of course isn't correct but that wasn't a problem > since highmem still is only supported on machines that don't have aliases. Thansk for good explanation. Chungki. Please let us know your machine(processor and cache configuration) > > Ralf > -- Kind regards, Minchan Kim |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Disable Function Tracer for Compressed kernel support part, Ralf Baechle |
|---|---|
| Next by Date: | [PATCH 1/2] tracing: convert trace_clock_local() as weak function, Wu Zhangjin |
| Previous by Thread: | Re: BUG? linux-mips flush_dcache_page, Ralf Baechle |
| Next by Thread: | [PATCH -queue 0/7] [loongson] A few Cleanups for fuloong2e, Wu Zhangjin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |