linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Wed, 14 Oct 2009 21:57:56 -0600
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=Mn/C5SrL53Yu6jxvns8Og8oGHtiYEo2niQ/fivb8clA=; b=G6QnZLteTNY4SEkN9AD/vpP2sai8nY/M2coFPLhaVNZ3e4X2DGy91nDDut2cYCBsdK ijZITj8EkvfxF94tDh8KuOQmn3yRSaX070gI147nTa79Re2frd/8iNrJYeHdOD6SalVr AVbXtTQK93ZldvHpJJOwqYxt5YjuL2hWlY6uw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=V5tzvSm/lNjqEW8d0d5MLTOx1+M3uiRdup9Ool2cL7tszySefusySNUud1woPraKuA ae/bbO3iLOY4OwGTIA4Q1BxW5Ixq3jIFCqYYHU2u56DKpJK+6TCQbXrBhGidhyFzJDFN EAzoVAH2J2QD2bbgzg+I3G3DSdhNW60SgY0cA=
In-reply-to: <20091014232518.GA621@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255546939-3302-1-git-send-email-dmitri.vorobiev@movial.com> <1255546939-3302-3-git-send-email-dmitri.vorobiev@movial.com> <b2b2f2320910141616p7b53c898gc4bc6a75713d4a8e@mail.gmail.com> <20091014232518.GA621@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Oct 14, 2009 at 5:25 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
On Wed, Oct 14, 2009 at 05:16:08PM -0600, Shane McDonald wrote:

> > Nobody calls the board-specific prom_getcmdline(), so let's remove it.
> >
> > Build-tested using msp71xx_defconfig.
> >
> > Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> >
> >
> NAK.  It is called by the MSP71xx's Ethernet driver, whose code has not yet
> made it into the mainline (last submission
> http://www.linux-mips.org/archives/linux-mips/2007-05/msg00210.html).
> Believe it or not, getting that driver whipped into shape is something I'm
> slowly (very slowly) working on.

At a glance, it's not outrageously bad so I suggest you submit it to be
merged into drivers/staging it least it will no longer suffer the bitrot
that out of tree drivers suffer from.

 Ralf

Good idea!  I'll need to clean it up enough so that it compiles and runs with HEAD, then I'll submit it to drivers/staging.

Shane

<Prev in Thread] Current Thread [Next in Thread>