linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 15 Oct 2009 01:25:18 +0200
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>, linux-mips@linux-mips.org
In-reply-to: <b2b2f2320910141616p7b53c898gc4bc6a75713d4a8e@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255546939-3302-1-git-send-email-dmitri.vorobiev@movial.com> <1255546939-3302-3-git-send-email-dmitri.vorobiev@movial.com> <b2b2f2320910141616p7b53c898gc4bc6a75713d4a8e@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Oct 14, 2009 at 05:16:08PM -0600, Shane McDonald wrote:

> > Nobody calls the board-specific prom_getcmdline(), so let's remove it.
> >
> > Build-tested using msp71xx_defconfig.
> >
> > Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> >
> >
> NAK.  It is called by the MSP71xx's Ethernet driver, whose code has not yet
> made it into the mainline (last submission
> http://www.linux-mips.org/archives/linux-mips/2007-05/msg00210.html).
> Believe it or not, getting that driver whipped into shape is something I'm
> slowly (very slowly) working on.

At a glance, it's not outrageously bad so I suggest you submit it to be
merged into drivers/staging it least it will no longer suffer the bitrot
that out of tree drivers suffer from.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>