linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function

To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Subject: Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Wed, 14 Oct 2009 17:16:08 -0600
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=zMBc1b2e0p4WMDAaO0QfOD455s216b49l3GZXxLPoBY=; b=GEMRH1pstMaVgR/iuglmrid0uQPIDNZQjPJ4mGMEJPY3R21gOClC9bgehT99pv24gn 6Fai+0+FL/5T7yMeCG2QISHGLl0UVDmmcPfTcpjQDFGEraglNkQiEweoqZXjd+VSlGoF vp9IppKp9j4z8WX0C9uAEw5sba5YjZ0NHopvQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=pqlppYKe42N/7GSxEFN+/eL9Ty36rp6f0mdC6nQ8eiFwbwwEKwL1pFQM/oaUNgev3v B4+tWmiZAnLEBG+OJSTBI5apzqUfsfNVBd2mrT0WG0iy1dWFRhTnop9eM+mAofVYf/fk RWi6t9h3pZ0/Ckhg4tMYo6RpmuNdyyuF7fdu4=
In-reply-to: <1255546939-3302-3-git-send-email-dmitri.vorobiev@movial.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255546939-3302-1-git-send-email-dmitri.vorobiev@movial.com> <1255546939-3302-3-git-send-email-dmitri.vorobiev@movial.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Oct 14, 2009 at 1:02 PM, Dmitri Vorobiev <dmitri.vorobiev@movial.com> wrote:
Nobody calls the board-specific prom_getcmdline(), so let's remove it.

Build-tested using msp71xx_defconfig.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>


NAK.  It is called by the MSP71xx's Ethernet driver, whose code has not yet made it into the mainline (last submission http://www.linux-mips.org/archives/linux-mips/2007-05/msg00210.html).  Believe it or not, getting that driver whipped into shape is something I'm slowly (very slowly) working on.

Shane McDonald
<Prev in Thread] Current Thread [Next in Thread>