linux-mips
[Top] [All Lists]

Re: [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Wed, 14 Oct 2009 09:06:13 +0800
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-mips@linux-mips.org, Sergei Shtylyov <sshtylyov@ru.mvista.com>, Pavel Machek <pavel@ucw.cz>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=LdHpNCBZOkFyFK+lrNheTYFGoEewgdfaMeaW74CL9dI=; b=ZrNnAdszgOfiGqVWsYvy7qQiIU1US4v/yT4VtiKGEeT9Dll8drm/f5ifpaKHPllBvV F0cxVVdGNFVAVJbAKv5dlo71kBvnitFB0Mb5qFV3yToN8R4Tzbx9b1eRQNjYqqpx43d5 VtPl9kd2z2uSXtfG7ozyM8MKU8GiJq7hREGes=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=kLrXOtxH7s8mRuEZli9NKLx2rlwKcCzu4JuX4ciQkJ2fvYzEPelHQwDlrEf4jGX0GQ jW3K72WYM0uhlzyL4GgNZDKf9/APdq287XAVTIwujO/1xrnwgMIFX2VFFVujFO7AXrib m6WdSa17e8u6SHfoVWNVhztfNkZyHfYZ7rYXY=
In-reply-to: <20091013220417.GA32099@linux-mips.org>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255001548-30567-1-git-send-email-wuzhangjin@gmail.com> <200910082221.12649.rjw@sisk.pl> <20091008204447.GA14560@linux-mips.org> <1255054108.5810.74.camel@falcon> <1255104130.3658.122.camel@falcon> <20091013220417.GA32099@linux-mips.org>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Wed, 2009-10-14 at 00:04 +0200, Ralf Baechle wrote:
> On Sat, Oct 10, 2009 at 12:02:10AM +0800, Wu Zhangjin wrote:
> 
> > The above patch can not fix the problem when enabled FLATMEM in
> > linux-2.6.32-rc3, the real problem should be that we need register the
> > "pci memory space" as nosave pages, and also, the above "reserved"(not
> > memory) pages should be registered as nosave pages. but the simpler
> > solution should be the pfn_valid() I sent out in this E-mail thread, we
> > just need to check whether they are "valid", if they are "System
> > RAM"(BOOT_MEM_RAM or BOOT_MEM_ROM_DATA), they should be valid.
> > 
> > and what's more? should be register "pci memory space" as nosave pages
> > for all architecture?
> 
> No.  You only see this problem because your PCI memory space is between
> the lowest and the highest memory address.  Other systems don't have this
> issue because they either use the discontig or sparse memory models.
> 
> Btw, for systems that actually have memory in the 90000000-bfffffff range
> and are running a 64-bit kernel with 4k ages the flatmem memory model
> will waste 28MB of RAM; with 16k pages it's still 7MB.
> 
> Time to say gooebye to flatmem?

Okay, I will enable SPARSEMEM by default in the defconfig later.

Regards,
        Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>