linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 12 Oct 2009 00:53:20 +0200
Cc: mbizon@freebox.fr, linux-mips@linux-mips.org
In-reply-to: <200908312337.36634.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200908312028.10931.florian@openwrt.org> <1251750389.10420.24.camel@sakura.staff.proxad.net> <200908312337.36634.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Aug 31, 2009 at 11:37:31PM +0200, Florian Fainelli wrote:

> Le lundi 31 août 2009 22:26:29, Maxime Bizon a écrit :
> > On Mon, 2009-08-31 at 20:28 +0200, Florian Fainelli wrote:
> > > This patch makes the GPIO pin multiplexing configuration
> > > read the initial GPIO mode register value instead of
> > > setting it initially to 0, then setting the correct
> > > bits, this is safer.
> >
> > I disagree, now we get working or not working devices depending on the
> > CFE version used, for which we don't have any public source code nor
> > changelog.
> 
> I did not think this could break other boards, it is required on BCM6345 
> though.
> 
> >
> > I cleared the register for that purpose.
> >
> > If a particular pin muxing config is needed for some board, we should
> > add this to the board specific struct instead.
> 
> Then I will make it BCM6345 specific.

I thought you were going to send an update to this?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>