linux-mips
[Top] [All Lists]

Re: [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUD

To: wuzhangjin@gmail.com
Subject: Re: [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUDIO
From: Andres Salomon <dilinger@collabora.co.uk>
Date: Sat, 10 Oct 2009 11:34:36 -0400
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mips <linux-mips@linux-mips.org>, Jaya Kumar <jayakumar.lkml@gmail.com>, Jaroslav Kysela <perex@perex.cz>, loongson-dev@googlegroups.com
In-reply-to: <1255185134.6883.20.camel@falcon>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255059842-12160-1-git-send-email-wuzhangjin@gmail.com> <1255060287.16819.1.camel@falcon> <20091009005318.7174938c@mycelium.queued.net> <1255185134.6883.20.camel@falcon>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 10 Oct 2009 22:32:14 +0800
Wu Zhangjin <wuzhangjin@gmail.com> wrote:

> Hello,
> 
> On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote:
> > On Fri, 09 Oct 2009 11:51:27 +0800
> > Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > 
> > > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > > > There is no platform dependence of SND_CS5535AUDIO before
> > > > 2.6.31, Not sure who have touched this part, but
> > > > SND_CS5535AUDIO is at least available on Loongson family
> > > > machines, so, Remove the platform dependence directly.
> > > > 
> > > > Reported-by: rixed@happyleptic.org
> > > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> > > > ---
> > > >  sound/pci/Kconfig |    1 -
> > > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > > > index fb5ee3c..75c602b 100644
> > > > --- a/sound/pci/Kconfig
> > > > +++ b/sound/pci/Kconfig
> > > > @@ -259,7 +259,6 @@ config SND_CS5530
> > > >  
> > > >  config SND_CS5535AUDIO
> > > >         tristate "CS5535/CS5536 Audio"
> > > > -       depends on X86 && !X86_64
> > > 
[...]
> 
> Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64,
> no compiling warnings & errors, but I don't have such a chip in a
> x86-64 machine, so, did not test the kernel yet.
> 
> Regards,
>       Wu Zhangjin
> 

Great, feel free to add

Acked-by: Andres Salomon <dilinger@collabora.co.uk>

<Prev in Thread] Current Thread [Next in Thread>