linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: Octeon: Add USB platform device.

To: Stefan Roese <sr@denx.de>
Subject: Re: [PATCH 1/2] MIPS: Octeon: Add USB platform device.
From: David Daney <ddaney@caviumnetworks.com>
Date: Fri, 09 Oct 2009 08:39:33 -0700
Cc: Markus Gothe <nietzsche@lysator.liu.se>, ralf@linux-mips.org, linux-mips@linux-mips.org, linux-usb@vger.kernel.org, gregkh@suse.de
In-reply-to: <200910090935.55346.sr@denx.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4ACD2EBF.8020901@caviumnetworks.com> <39A458B3-45D1-405E-A3F1-E41A6DB7EDE8@lysator.liu.se> <4ACE53A9.8080504@caviumnetworks.com> <200910090935.55346.sr@denx.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Stefan Roese wrote:
On Thursday 08 October 2009 23:03:37 David Daney wrote:
If you look at '[PATCH 2/2] USB: Add HCD for Octeon SOC', you will see
that it has the hcd support.  I have omitted pcd support from this set,
as I am working towards getting hcd mergable first.

As for endian issues, the current Octeon support in the kernel is for
big-endian only, so since the usb hardware is on the same chip as the
CPU, endian safety is not currently an issue.  I have heard rumors that
some ralink and PPC variants have the same controller, but I have no way
of confirming this or even testing the code as I don't have that
hardware.

Yes, this Synopsys USB-OTG core is also integrated in some AMCC (Applied Micro) PowerPC's (e.g. PPC405EX and PPC460EX). So we should try to make this driver usable by those platforms as well. But this could be done in a later step.

I can only refer you to '[PATCH 2/2] USB: Add HCD for Octeon SOC' (unfortunately eaten by linux-usb but available in the linux-mips archives), The target specific code is all in dwc_otg_octeon.c. The rest should be target independent. My expectation is that, much as the ohci and ehci drivers have target specific code spilt out, we would do the same with dwc_otg.



David, on which Synopsys driver version did you base your driver? The latest version available is 2.90a IIRC.


It has this annotation:

 "2.40a 10-APR-2006"

We have made local bug fixes though.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de



<Prev in Thread] Current Thread [Next in Thread>