linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: Octeon: Add USB platform device.

To: Markus Gothe <nietzsche@lysator.liu.se>
Subject: Re: [PATCH 1/2] MIPS: Octeon: Add USB platform device.
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 08 Oct 2009 14:03:37 -0700
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-usb@vger.kernel.org, gregkh@suse.de
In-reply-to: <39A458B3-45D1-405E-A3F1-E41A6DB7EDE8@lysator.liu.se>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4ACD2EBF.8020901@caviumnetworks.com> <1254960926-12185-1-git-send-email-ddaney@caviumnetworks.com> <39A458B3-45D1-405E-A3F1-E41A6DB7EDE8@lysator.liu.se>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Markus Gothe wrote:
Is this just the HCD part AND is it tested to be endian safe?


This particular patch just adds platform devices for the Octeon SOC.

The main patch (Patch 2/2) can be seen here:

http://marc.info/?l=linux-mips&m=125502126531841&w=2

For some reason it hasn't come out on linux-usb yet.

If you look at '[PATCH 2/2] USB: Add HCD for Octeon SOC', you will see that it has the hcd support. I have omitted pcd support from this set, as I am working towards getting hcd mergable first.

As for endian issues, the current Octeon support in the kernel is for big-endian only, so since the usb hardware is on the same chip as the CPU, endian safety is not currently an issue. I have heard rumors that some ralink and PPC variants have the same controller, but I have no way of confirming this or even testing the code as I don't have that hardware.


Think of a 16-bits BE GIO-bus connected to the LE-32 HCD. (It's an incredible mess to debug that kind of setup...)


Indeed.

David Daney


//Markus Gothe - The panamahat hacker

On 8 Oct 2009, at 02:15, David Daney wrote:

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
arch/mips/cavium-octeon/octeon-platform.c      |  105 ++
arch/mips/include/asm/octeon/cvmx-usbcx-defs.h | 1199 ++++++++++++++++++++++++
[...]

<Prev in Thread] Current Thread [Next in Thread>