linux-mips
[Top] [All Lists]

Re: [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM

To: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH -v1] MIPS: fix pfn_valid() for FLATMEM
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 8 Oct 2009 22:44:47 +0200
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, linux-mips@linux-mips.org, Sergei Shtylyov <sshtylyov@ru.mvista.com>, Pavel Machek <pavel@ucw.cz>
In-reply-to: <200910082221.12649.rjw@sisk.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255001548-30567-1-git-send-email-wuzhangjin@gmail.com> <200910082221.12649.rjw@sisk.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Oct 08, 2009 at 10:21:12PM +0200, Rafael J. Wysocki wrote:

> > Here, we fix it via checking pfn is in the "System RAM" or not. and
> > Seems pfn_valid() is not called in assembly code, we move it to
> > "!__ASSEMBLY__" to ensure we can simply declare it via "extern int
> > pfn_valid(unsigned long)" without Compiling Error.
> > 
> > (This -v1 version incorporates feedback from Pavel Machek <pavel@ucw.cz>
> >  and Sergei Shtylyov <sshtylyov@ru.mvista.com>)
> 
> Hmm.  What exactly would be wrong with using register_nosave_region() or
> register_nosave_region_late() like x86 does?

That seems to be more the fix than pfn_valid / PageReserved fiddlery we were
discussing in the other thread.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>