linux-mips
[Top] [All Lists]

Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite
From: Wolfram Sang <w.sang@pengutronix.de>
Date: Sat, 3 Oct 2009 12:22:21 +0200
Cc: linux-pcmcia <linux-pcmcia@lists.infradead.org>, Linux-MIPS <linux-mips@linux-mips.org>, Florian Fainelli <florian@openwrt.org>, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <f861ec6f0910020732p2ff76990q1e7a2bca16e52e64@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1254250236-18130-1-git-send-email-manuel.lauss@gmail.com> <20091002105903.GC3179@pengutronix.de> <f861ec6f0910020415j5125295fn6b5dff7db4bf170e@mail.gmail.com> <20091002125423.GD3179@pengutronix.de> <f861ec6f0910020732p2ff76990q1e7a2bca16e52e64@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
> > Yeah, I saw that you want to remove it, still I don't know why :) Is it 
> > feature
> > incomplete and updating is impossible? Is the concept outdated? Could you
> > enlighten me on that?
> 
> I started out with the intention to fix its styling issues, add carddetect irq
> support, etc.  In the end it was easier to write a quick-and-dirty standalone
> full-features socket driver for the DB1200 and extend it to support the
> other DB/PB boards. While I was at it I modified my driver for the xxs1500,
> that's all.

Okay, that explains.

> 
> The only *technical* reason I have is a personal dislike for how the current
> one works: it forces every conceivable board to add dozens of cpp macros
> for mem/io ranges and gets registered by board-independent code.
> Hardly convincing, I know.

Well, you have the (to me) pretty convincing technical argument that your
drivers provide more features and less crashes which is a clear benefit for
users. If we remove the generic au1000-part, then it might even be in the same
amount in LoC. Okay, we lose a bit of maintainability if a bug is found in a
section which was shared among the former users of generic, as it has to be
updated for each of the three drivers, but well... Are there any plans to
convert pb1x00 as well?

Maybe I find time to look a bit more into it, but I can't test anything, of
course, so the more additional comments/test-reports the better.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>