linux-mips
[Top] [All Lists]

Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite
From: Wolfram Sang <w.sang@pengutronix.de>
Date: Fri, 2 Oct 2009 14:54:23 +0200
Cc: linux-pcmcia <linux-pcmcia@lists.infradead.org>, Linux-MIPS <linux-mips@linux-mips.org>, Florian Fainelli <florian@openwrt.org>, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <f861ec6f0910020415j5125295fn6b5dff7db4bf170e@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1254250236-18130-1-git-send-email-manuel.lauss@gmail.com> <20091002105903.GC3179@pengutronix.de> <f861ec6f0910020415j5125295fn6b5dff7db4bf170e@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
> >> Rewritten XXS1500 PCMCIA socket driver, standalone (doesn't
> >> depend on au1000_generic.c) and added carddetect IRQ support.
> >
> > I am not familiar with the details here. Why did you choose to drop the 
> > generic
> > au1000-part for this and the other driver?
> 
> I want to get rid of au1000_generic.[ch] eventually or at least all of its
> contents except the static mapping and resource allocation functions, which
> are board- independent.  On the other hand these are so short that I opted to
> just duplicate them into the xxs1500_ss.c and db1xxx_ss.c (other patch)
> files.  The db1xxx_ss (for the Alchemy demoboards) is supposed to be an
> example on how to set up PCMCIA on Alchemy SoCs.

Yeah, I saw that you want to remove it, still I don't know why :) Is it feature
incomplete and updating is impossible? Is the concept outdated? Could you
enlighten me on that?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>