linux-mips
[Top] [All Lists]

Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite

To: Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH] Alchemy: XXS1500 PCMCIA driver rewrite
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Fri, 2 Oct 2009 13:15:59 +0200
Cc: linux-pcmcia <linux-pcmcia@lists.infradead.org>, Linux-MIPS <linux-mips@linux-mips.org>, Florian Fainelli <florian@openwrt.org>, Manuel Lauss <manuel.lauss@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=H2sHoB9BKG5T1itKZjbNJSqUpnIOI0mPtXxDOJ+SKSw=; b=pXYqxY2SgaCpNZYOih/YdM59urKGSRn2n+tZycx8JFH2NllaEE9LvqpSNWZdGoKK7n JJisEHllYvuyBZwAKZtnZS3GhUyCMEkJbHcLldpfJrNU7TnEJ+176LMvm8kS63rK8cT3 rH5VlK4QZpnXn5EwhjwC/IG9XVu4l4zaDzfoA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=xmtByGvP04HKAnulglSYplFqveBf8Dz3aOAYDqig7dEYorgVHzn2YeiVulo2oQEzRm oYmPFSd/CfCvg3KPVOdlZZ9f4hpOhfxSXcujeEnT5bLp7yT+8H21lTw23k4XXDVnmgl4 1c3yCVmlKIMUYDVBEI06aSpZ8jPxT/lOIqNNQ=
In-reply-to: <20091002105903.GC3179@pengutronix.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1254250236-18130-1-git-send-email-manuel.lauss@gmail.com> <20091002105903.GC3179@pengutronix.de>
Sender: linux-mips-bounce@linux-mips.org
Servus Wolfram,

On Fri, Oct 2, 2009 at 12:59 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
>
>> Rewritten XXS1500 PCMCIA socket driver, standalone (doesn't
>> depend on au1000_generic.c) and added carddetect IRQ support.
>
> I am not familiar with the details here. Why did you choose to drop the 
> generic
> au1000-part for this and the other driver?

I want to get rid of au1000_generic.[ch] eventually or at least all of
its contents
except the static mapping and resource allocation functions, which are board-
independent.  On the other hand these are so short that I opted to
just duplicate
them into the xxs1500_ss.c and db1xxx_ss.c (other patch) files.  The db1xxx_ss
(for the Alchemy demoboards) is supposed to be an example on how to set up
PCMCIA on Alchemy SoCs.

Danke,
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>