linux-mips
[Top] [All Lists]

Re: [PATCH] When complaining about attempting to set the irq affinity to

To: Mark Mason <mmason@upwardaccess.com>
Subject: Re: [PATCH] When complaining about attempting to set the irq affinity to multiple cpus,
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 23 Sep 2009 21:50:04 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1253567604-6734-1-git-send-email-mmason@upwardaccess.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1253567604-6734-1-git-send-email-mmason@upwardaccess.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Sep 21, 2009 at 02:13:24PM -0700, Mark Mason wrote:

>  arch/mips/sibyte/bcm1480/irq.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/sibyte/bcm1480/irq.c b/arch/mips/sibyte/bcm1480/irq.c
> index ba59839..fc87ea4 100644
> --- a/arch/mips/sibyte/bcm1480/irq.c
> +++ b/arch/mips/sibyte/bcm1480/irq.c
> @@ -118,7 +118,11 @@ static int bcm1480_set_affinity(unsigned int irq, const 
> struct cpumask *mask)
>       unsigned int irq_dirty;
>  
>       if (cpumask_weight(mask) != 1) {
> -             printk("attempted to set irq affinity for irq %d to multiple 
> CPUs\n", irq);
> +             printk("attempted to set irq affinity for irq %d to multiple 
> CPUs:", irq);
> +             /* Print the mask */
> +             for_each_cpu(i, mask)
> +                     printk(" %d", i);
> +             printk("\n");

The whole if block is a zombie that was supposed to have been
removed by commit 14275ccdb1e4b487cca745aba994699c426a31ee but then
returned in 92241940be501f798cb21db344bbb3d1ec3c4f1c.  So I went for a
slightly different patch, see below.

Thanks,

  Ralf

MIPS: BCM1480: Re-apply patch lost due to bad resolution of merge conflict.

Patch 14275ccdb1e4b487cca745aba994699c426a31ee and
d5dedd4507d307eb3f35f21b6e16f336fdc0d82a are conflicting and the
conflict was resolved badly in merge
92241940be501f798cb21db344bbb3d1ec3c4f1c resulting in the BCM1480 changes
of 14275ccdb1e4b487cca745aba994699c426a31ee getting lost.  Sort out the
damage.

Reported and initial patch by Mark Mason <mmason@upwardaccess.com>.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/sibyte/bcm1480/irq.c b/arch/mips/sibyte/bcm1480/irq.c
index ba59839..4070268 100644
--- a/arch/mips/sibyte/bcm1480/irq.c
+++ b/arch/mips/sibyte/bcm1480/irq.c
@@ -117,10 +117,6 @@ static int bcm1480_set_affinity(unsigned int irq, const 
struct cpumask *mask)
        unsigned long flags;
        unsigned int irq_dirty;
 
-       if (cpumask_weight(mask) != 1) {
-               printk("attempted to set irq affinity for irq %d to multiple 
CPUs\n", irq);
-               return -1;
-       }
        i = cpumask_first(mask);
 
        /* Convert logical CPU to physical CPU */

<Prev in Thread] Current Thread [Next in Thread>