linux-mips
[Top] [All Lists]

Re: [PATCH] arch/mips: remove duplicate structure field initialization

To: Julia Lawall <julia@diku.dk>, "Kevin D. Kissell" <kevink@paralogos.com>
Subject: Re: [PATCH] arch/mips: remove duplicate structure field initialization
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 21 Sep 2009 20:25:20 +0100
Cc: dmitri.vorobiev@gmail.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
In-reply-to: <Pine.LNX.4.64.0909211708200.8549@pc-004.diku.dk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64.0909211708200.8549@pc-004.diku.dk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Sep 21, 2009 at 05:08:55PM +0200, Julia Lawall wrote:

Adding Kevin "SMTC Kissel to cc.

> From: Julia Lawall <julia@diku.dk>
> 
> The definition of the irq_ipi structure has two initializations of the
> flags field.  This combines them.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> identifier I, s, fld;
> position p0,p;
> expression E;
> @@
> 
> struct I s =@p0 { ... .fld@p = E, ...};
> 
> @s@
> identifier I, s, r.fld;
> position r.p0,p;
> expression E;
> @@
> 
> struct I s =@p0 { ... .fld@p = E, ...};
> 
> @script:python@
> p0 << r.p0;
> fld << r.fld;
> ps << s.p;
> pr << r.p;
> @@
> 
> if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
>   cocci.print_main(fld,p0)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>
> 
> ---
>  arch/mips/kernel/smtc.c             |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/kernel/smtc.c b/arch/mips/kernel/smtc.c
> index 67153a0..4d181df 100644
> --- a/arch/mips/kernel/smtc.c
> +++ b/arch/mips/kernel/smtc.c
> @@ -1098,9 +1098,8 @@ static void ipi_irq_dispatch(void)
>  
>  static struct irqaction irq_ipi = {
>       .handler        = ipi_interrupt,
> -     .flags          = IRQF_DISABLED,
> -     .name           = "SMTC_IPI",
> -     .flags          = IRQF_PERCPU
> +     .flags          = IRQF_DISABLED | IRQF_PERCPU,
> +     .name           = "SMTC_IPI"
>  };
>  
>  static void setup_cross_vpe_interrupts(unsigned int nvpe)

The actual semantic of this code as implemented by gcc is that all but the
last initializer are ignored so until somebody actually tests your code
I'll just remove the first of the two initializers and put a comment there.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>