Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap

[Atsushi Nemoto <anemo@mba.ocn.ne.jp>]

On Tue, 15 Sep 2009 07:03:42 +0200 (CEST), Julia Lawall <julia@diku.dk> wrote:
> > +out_pdev:
> > +   platform_device_put(pdev);
> > +out_gpio:
> > +   gpio_remove(&iocled->chip);
> 
> I just noticed that the prototype of gpio_remove has __must_check
> I don't think there is anything to check here; since the thing is not 
> fully initialized here, it is unlikely to be busy.  Should there be (void) 
> in front of it?

The void casting does not silence the warning.  How about this?

        if (gpiochip_remove(&iocled->chip))
                return;

In general, memory leak would be less serious than crash or data
corruption ;)

---
Atsushi Nemoto