| To: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap |
| From: | Julia Lawall <julia@diku.dk> |
| Date: | Tue, 15 Sep 2009 07:03:42 +0200 (CEST) |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org |
| In-reply-to: | <Pine.LNX.4.64.0909132113520.31000@ask.diku.dk> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <Pine.LNX.4.64.0909111820370.10552@pc-004.diku.dk> <20090913.232548.253168283.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64.0909131708190.25903@ask.diku.dk> <20090914.003321.160496287.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64.0909132113520.31000@ask.diku.dk> |
| Sender: | linux-mips-bounce@linux-mips.org |
> +out_pdev: > + platform_device_put(pdev); > +out_gpio: > + gpio_remove(&iocled->chip); I just noticed that the prototype of gpio_remove has __must_check I don't think there is anything to check here; since the thing is not fully initialized here, it is unlikely to be busy. Should there be (void) in front of it? julia |
| Previous by Date: | [PATCH 00/11] Add support for GCC's __builtin_unreachable() and use it in BUG (v2)., David Daney |
|---|---|
| Next by Date: | Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap, Ralf Rösch |
| Previous by Thread: | Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap, Ralf Baechle |
| Next by Thread: | Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |