linux-mips
[Top] [All Lists]

Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap

To: julia@diku.dk
Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 13 Sep 2009 23:25:48 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
In-reply-to: <Pine.LNX.4.64.0909111820370.10552@pc-004.diku.dk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64.0909111820370.10552@pc-004.diku.dk>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 11 Sep 2009 18:21:00 +0200 (CEST), Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> Error handling code following a kzalloc should free the allocated data.
> Error handling code following an ioremap should iounmap the allocated data.
> 
> The semantic match that finds the first problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)

Thank you for finding this out.

This patch add some correctness, but obviously incomplete: there are
more error pathes without iounmap/kfree/etc. in this function.

And I like goto-style cleanup, as Mark Brown said in reply for your
sound/soc patch.

Could you make a new patch?

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>