| To: | mbizon@freebox.fr |
|---|---|
| Subject: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings |
| From: | Florian Fainelli <florian@openwrt.org> |
| Date: | Mon, 31 Aug 2009 23:37:31 +0200 |
| Cc: | ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=iJz1YPZxFmcDPJqMCInWzTB55vZBn9Cfmtn9oje4Mu4=; b=fZqt1vfvkVW70npGA5BMGo2BXIcS2ZT1oMexUF51QcN8ncL9KwqfC/Y/mf7RBRb+6G grZXsJIbMIqpoF+FPnG4Olp4fUQmMSYS5L8mfHBmKn5nAS4+M+ODtSigvlDcCSM98II0 W16qhr4wSelt4HM30s9U1oNx4Erf4Mnt3/UdQ= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=MJRb+oXOHeSzHQx/nSLs7QdSjZAvZOc3BupfNHZ7AFAnR6uVIWYDqI6W0NCIK2AkNf FcAqq+qRev+b8S7pM4T/EuM52dTUuAuJdWxElc9G7yX36JsIBwqOnGasgGMnEDeRxOz0 F6qWFwolUhMDynkSgtIzbvKVaVSNXHbJG3/Gg= |
| In-reply-to: | <1251750389.10420.24.camel@sakura.staff.proxad.net> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200908312028.10931.florian@openwrt.org> <1251750389.10420.24.camel@sakura.staff.proxad.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | KMail/1.11.4 (Linux/2.6.29-2-686; KDE/4.2.4; i686; ; ) |
Le lundi 31 août 2009 22:26:29, Maxime Bizon a écrit : > On Mon, 2009-08-31 at 20:28 +0200, Florian Fainelli wrote: > > This patch makes the GPIO pin multiplexing configuration > > read the initial GPIO mode register value instead of > > setting it initially to 0, then setting the correct > > bits, this is safer. > > I disagree, now we get working or not working devices depending on the > CFE version used, for which we don't have any public source code nor > changelog. I did not think this could break other boards, it is required on BCM6345 though. > > I cleared the register for that purpose. > > If a particular pin muxing config is needed for some board, we should > add this to the board specific struct instead. Then I will make it BCM6345 specific. Thanks. -- Best regards, Florian Fainelli Email: florian@openwrt.org Web: http://openwrt.org IRC: [florian] on irc.freenode.net -------------------------------
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Maxime Bizon |
|---|---|
| Previous by Thread: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Maxime Bizon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |