| To: | Florian Fainelli <florian@openwrt.org> |
|---|---|
| Subject: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings |
| From: | Maxime Bizon <mbizon@freebox.fr> |
| Date: | Mon, 31 Aug 2009 22:26:29 +0200 |
| Cc: | ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <200908312028.10931.florian@openwrt.org> |
| Organization: | Freebox |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200908312028.10931.florian@openwrt.org> |
| Reply-to: | mbizon@freebox.fr |
| Sender: | linux-mips-bounce@linux-mips.org |
On Mon, 2009-08-31 at 20:28 +0200, Florian Fainelli wrote: > This patch makes the GPIO pin multiplexing configuration > read the initial GPIO mode register value instead of > setting it initially to 0, then setting the correct > bits, this is safer. I disagree, now we get working or not working devices depending on the CFE version used, for which we don't have any public source code nor changelog. I cleared the register for that purpose. If a particular pin muxing config is needed for some board, we should add this to the board specific struct instead. -- Maxime |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Florian Fainelli |
|---|---|
| Next by Date: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Florian Fainelli |
| Previous by Thread: | [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Florian Fainelli |
| Next by Thread: | Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |