linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] ar7_wdt: convert to become a platform driver

To: Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 2/2] ar7_wdt: convert to become a platform driver
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 31 Aug 2009 15:42:58 +0200
Cc: ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=E+j6hWZFobALOgswJJAoLWVqWyZfTa9MBGmmQ+8S+u0=; b=VF4/WLWymE5gttr6MN7CBoh/15f0TkVF0uy5Or3SPTj+CEnZO7T9+UeDxV5kbegKc1 KAkhpVZus8/xJfpygFtXgbee7RtIDZiRAvSEb0IHUhDaE4Od7l8epb+SDfikjytf8X3f 2ymdtQ1eln/sX1I4icbs2sCdlYfxEvcS644Qc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=EXeBCjvjfnDsLfljYIFR4V5JfBflEquvH6F0aNWYIPsoPuw8paDYZ57lkNuj5Xx9+R TcKvXS+uVsYCUePYy2GR+esQh5XxPvGjXMOwH4vpuilNsdyTRdhU6fn4JRkB1+pt7KwC TC48VEl5p7TWfuO7LBqCmr5I20fEr3ENxK4AQ=
In-reply-to: <20090827204719.GM29382@infomag.iguana.be>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200907151210.20294.florian@openwrt.org> <200908111517.09726.florian@openwrt.org> <20090827204719.GM29382@infomag.iguana.be>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.11.4 (Linux/2.6.29-2-686; KDE/4.2.4; i686; ; )
Le jeudi 27 août 2009 22:47:19, Wim Van Sebroeck a écrit :
> Hi Florian,
>
> > > > > From: Florian Fainelli <florian@openwrt.org>
> > > > > Subject: [PATCH 2/2 v2] ar7_wdt: convert to become a platform
> > > > > driver
> > > > >
> > > > > This patch converts the ar7_wdt driver to become
> > > > > a platform driver. The AR7 SoC specific identification
> > > > > and base register calculation is performed by the board
> > > > > code, therefore we no longer need to have access to
> > > > > ar7_chip_id. We also remove the reboot notifier code to
> > > > > use the platform shutdown method as Wim suggested.
> > > > >
> > > > > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > > > > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> > > >
> > > > Any news on this patch ?
> > >
> > > This one was ok for me. I think we agreed that Ralf would take it up in
> > > his tree. I can also take it up in my next tree still.
> >
> > Oh, I did not understand that sorry, I thought Ralf would take the first
> > one which is MIPS-specific.
>
> I added the second patch to my tree, but saw that the error handling on
> probe could be improved. Can you test attached patch?

Works fine. Feel free to add my Tested-by: Florian Fainelli 
<florian@openwrt.org>. Thanks !
-- 
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>