linux-mips
[Top] [All Lists]

Re: kexec on mips failed

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: kexec on mips failed
From: Nicolas Schichan <nschichan@freebox.fr>
Date: Fri, 28 Aug 2009 15:23:47 +0200
Cc: "wilbur.chan" <wilbur512@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <200908281109.52499.florian@openwrt.org>
Organization: Freebox
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <e997b7420908160920y14d8ea95v5fb25eba67e7b6db@mail.gmail.com> <200908281109.52499.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.11.2 (Linux/2.6.28-14-generic; KDE/4.2.2; x86_64; ; )
On Friday 28 August 2009 11:09:51 am Florian Fainelli wrote:
> Hi,

Hi,

> > However, whether I changed kexec_start_address to 0x802b0000 or
> > 0x2b0000 , the  'j  s1'  seemed taking no effect?
> 
> Should not you add a nop right after the j s1 in order to fill in the branch 
> delay slot with an instruction which does nothing ?

This should not be needed since  have no ".set noreorder" in the file,
so the  assembler should add a nop  in the delay slot,  after "jr s1".

I have this  on an objdumped relocate_kernel.o, so  the assembler does
add the nop:

[...]
000000a4 <done>:
  a4:   02200008        jr      s1
  a8:   00000000        nop
[...]

Regards,

-- 
Nicolas Schichan

<Prev in Thread] Current Thread [Next in Thread>