linux-mips
[Top] [All Lists]

Re: MTX build failure

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: MTX build failure
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 28 Aug 2009 14:14:06 +0100
Cc: Florian Fainelli <florian@openwrt.org>, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <4A97A2E2.2090108@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090828074709.GA11637@linux-mips.org> <4A979B0E.106@gmail.com> <4A97A2E2.2090108@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Fri, Aug 28, 2009 at 11:26:58AM +0200, Manuel Lauss wrote:

> I wrote:
> > Ralf Baechle wrote:
> >>   CC      drivers/input/keyboard/gpio_keys.o
> >> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In 
> >> function ‘gpio_keys_probe’:
> >> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: 
> >> error: implicit declaration of function ‘gpio_request’
> >> /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: 
> >> error: implicit declaration of function ‘gpio_free’
> >> make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
> >> make[4]: *** [drivers/input/keyboard] Error 2
> >> make[3]: *** [drivers/input] Error 2
> >> make[2]: *** [drivers] Error 2
> >> make[1]: *** [sub-make] Error 2
> > 
> > Either something like the patch below, or adding stubs for
> > gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the
> > CONFIG_GPIOLIB=n case should fix it.
> 
> Florian, Ralf, I prefer the latter approach;  saves everyone from
> having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.
> 
> Here's an untested patch.  What do you think?  If it works for you, please
> add it to your patchqueue!

Thanks, this 2nd one looks good.  Applied.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>