linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] ar7_wdt: convert to become a platform driver

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/2] ar7_wdt: convert to become a platform driver
From: Wim Van Sebroeck <wim@iguana.be>
Date: Thu, 27 Aug 2009 22:47:19 +0200
Cc: ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <200908111517.09726.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200907151210.20294.florian@openwrt.org> <200908111452.28418.florian@openwrt.org> <20090811130133.GH4302@infomag.iguana.be> <200908111517.09726.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Florian,

> > > > From: Florian Fainelli <florian@openwrt.org>
> > > > Subject: [PATCH 2/2 v2] ar7_wdt: convert to become a platform driver
> > > >
> > > > This patch converts the ar7_wdt driver to become
> > > > a platform driver. The AR7 SoC specific identification
> > > > and base register calculation is performed by the board
> > > > code, therefore we no longer need to have access to
> > > > ar7_chip_id. We also remove the reboot notifier code to
> > > > use the platform shutdown method as Wim suggested.
> > > >
> > > > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > > > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> > >
> > > Any news on this patch ?
> >
> > This one was ok for me. I think we agreed that Ralf would take it up in his
> > tree. I can also take it up in my next tree still.
> 
> Oh, I did not understand that sorry, I thought Ralf would take the first one 
> which is MIPS-specific.

I added the second patch to my tree, but saw that the error handling on probe 
could be improved.
Can you test attached patch?

Thanks in advance,
Wim.

Attachment: ar7_wdt-fix-probe-errors.diff
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>