linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] alchemy: add au1000-eth platform device

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/2] alchemy: add au1000-eth platform device
From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 18 Aug 2009 18:01:40 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Manuel Lauss <manuel.lauss@googlemail.com>, David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=YdMb4ehlYr8SCHj5XZgHZ0sc4wxAxWaeU4sISMCcFPI=; b=Isj0lEwtkmDgRClx0DrRVKNXYEjPK7Hom75VoRSiWwIeOzshphEH4+Xy2Fcyhfb1Jc zGEzYXuwKDqfn2lrC6R8xNLYQLAuN8wxWV6EhOWXt7O2GzPLHp6IoxKA9Dw0mXBqsbCk 9tJ7ryOt5/FZlf2VqkZuw4hMqDHn3jzEWGnLU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=mWFr/sOcAPqBujxJCDKeid/5X37+2XMcCRGmz3fyqqvtwyINLaxP+3vPd2tK/F4OIG /S0pd5zW1XDlwiZrISfGyF5VoE+G4ttzPN/tWARM6DkMWfH9qnZPlOGGgo0rWm8rfcAw cH4ZfIbstjh4adpPrbPzmM6fMhVW/unguia60=
In-reply-to: <4A8AC125.3020602@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200908170105.38154.florian@openwrt.org> <4A8AC125.3020602@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Tuesday 18 August 2009 16:56:37 Sergei Shtylyov, vous avez écrit :
> Hello.
>
> Florian Fainelli wrote:
> > This patch adds the board code to register a per-board au1000-eth
> > platform device to be used wit the au1000-eth platform driver in a
> > subsequent patch. Note that the au1000-eth driver knows about the
> > default driver settings such that we do not need to pass any
> > platform_data informations in most cases except db1x00.
>
>     Sigh, NAK...
>     Please don't register the SoC device per board, do it in
> alchemy/common/platfrom.c and find a way to pass the board specific
> platform data from the board file there instead -- something like
> arch/arm/mach-davinci/usb.c does.

Ok, like I promised, this was the per-board device registration. Do you prefer 
something like this:
--
<Prev in Thread] Current Thread [Next in Thread>