linux-mips
[Top] [All Lists]

Re: [PATCH] bcm63xx: fix build failures when CONFIG_PCI is disabled

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] bcm63xx: fix build failures when CONFIG_PCI is disabled
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 8 Aug 2009 12:10:29 +0100
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>
In-reply-to: <200908042214.39866.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200908042214.39866.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Aug 04, 2009 at 10:14:39PM +0200, Florian Fainelli wrote:

> This patch fixes multiple build failures when CONFIG_PCI
> is disabled. Since bcm63xx_sprom depends on CONFIG_SSB_PCIHOST
> to be set, which depends on CONFIG_PCI, bcm63xx_sprom
> would be unused thus causing this direct warning treated
> as an error:
> 
> cc1: warnings being treated as errors
> arch/mips/bcm63xx/boards/board_bcm963xx.c:466: warning: 'bcm63xx_sprom' 
> defined but not used
> 
> Then bcm63xx_pci_enabled would not be resolved since it
> is declared in arch/mips/pci/pci-bcm63xx.c which is not
> compiled due to CONFIG_PCI being disabled. Finally,
> ssb_set_arch_fallback would not be resolved too, since
> CONFIG_SSB_PCIHOST is disabled.

Thanks.  Folded into "MIPS: BCM63XX: Add board support code."

  Ralf

<Prev in Thread] Current Thread [Next in Thread>