linux-mips
[Top] [All Lists]

Re: [PATCH] ar7: register watchdog driver only if enabled in hardware co

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] ar7: register watchdog driver only if enabled in hardware configuration
From: Alexander Clouter <alex@digriz.org.uk>
Date: Wed, 5 Aug 2009 09:34:11 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <4A79407B.7070604@ru.mvista.com>
Organization: diGriz
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200908042309.36721.florian@openwrt.org> <62qmk6-g11.ln1@chipmunk.wormnet.eu> <4A79407B.7070604@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
Hi,

* Sergei Shtylyov <sshtylyov@ru.mvista.com> [2009-08-05 12:19:07+0400]:
> 
> Hello.
> 
> Alexander Clouter wrote:
> 
> > I think the 'correct' way to do this is:
> > ---
> > void __iomem *bootcr;
> > u32 val;
> > 
> > ...
> > 
> > bootcr = ioremap_nocache(AR7_REGS_DCL, 4);
> > val = *bootcr;
> >   
> 
> Wait, you can't dereference a pointer to void...
> 
bah,
----
val = __raw_readl(bootcr);
----

Cheers

-- 
Alexander Clouter
.sigmonster says: If you keep anything long enough, you can throw it away.

<Prev in Thread] Current Thread [Next in Thread>