linux-mips
[Top] [All Lists]

Re: [PATCH V2] au1xmmc: dev_pm_ops conversion

To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Sun, 26 Jul 2009 21:38:18 +0200
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Frans Pop <elendil@planet.nl>, Manuel Lauss <manuel.lauss@googlemail.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Manuel Lauss <manuel.lauss@gmail.com>
In-reply-to: <20090726150834.GB27022@sirena.org.uk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1248275919-3296-1-git-send-email-manuel.lauss@gmail.com> <200907252139.30674.rjw@sisk.pl> <20090726150834.GB27022@sirena.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.11.2 (Linux/2.6.31-rc4-rjw; KDE/4.2.4; x86_64; ; )
On Sunday 26 July 2009, Mark Brown wrote:
> On Sat, Jul 25, 2009 at 09:39:30PM +0200, Rafael J. Wysocki wrote:
> 
> > Yes, they would.  In general, you'd probably want to do something like this:
> 
> > static struct dev_pm_ops au1xmmc_pmops = {
> >     .resume         = au1xmmc_resume,
> >     .suspend                = au1xmmc_suspend,
> >     .freeze         = au1xmmc_resume,
> >     .thaw           = au1xmmc_suspend,
> 
> I'd have expected freeze and thaw to be the other way around here?

Sure, sorry.

.suspend() corresponds to .freeze() and .poweroff(), while .resume()
corresponds to .thaw() and .restore().

Best,
Rafael

<Prev in Thread] Current Thread [Next in Thread>