linux-mips
[Top] [All Lists]

Re: [PATCH V2] au1xmmc: dev_pm_ops conversion

To: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion
From: Frans Pop <elendil@planet.nl>
Date: Sat, 25 Jul 2009 22:21:42 +0200
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Manuel Lauss <manuel.lauss@googlemail.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Manuel Lauss <manuel.lauss@gmail.com>, Arnaud Faucher <arnaud.faucher@gmail.com>, Erik Ekman <erik@kryo.se>, Mark Brown <broonie@opensource.wolfsonmicro.com>
In-reply-to: <200907252139.30674.rjw@sisk.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1248275919-3296-1-git-send-email-manuel.lauss@gmail.com> <20090725191037.GE14062@dtor-d630.eng.vmware.com> <200907252139.30674.rjw@sisk.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
On Saturday 25 July 2009, Rafael J. Wysocki wrote:
> > > > Was suspend to disk tested? It requires freeze()/thaw().
> > >
> > > Is that a regression introduced by this patch then? If so, many
> > > more of the recent dev_pm_ops conversion patches would need to be
> > > revisited.
>
> Yes, they would.  In general, you'd probably want to do something like
> this:
>
> static struct dev_pm_ops au1xmmc_pmops = {
>         .resume         = au1xmmc_resume,
>         .suspend                = au1xmmc_suspend,
>         .freeze         = au1xmmc_resume,
>         .thaw           = au1xmmc_suspend,
>         .restore                = au1xmmc_resume,
>         .poweroff       = au1xmmc_suspend,
> };
>
> but in this particular case it's probably better to define separate
> callbacks for .freeze() and .thaw() at least.
>
> During hibernation we call .freeze() and .thaw() before and after
> creating the image, respectively, and then .poweroff() is called right
> after the image has been saved.  During resume .freeze() is called
> after the image has been loaded and before the control goes to the
> image kernel, which then calls .restore().

Yes, I see that in drivers/base/platform.c (legacy) .suspend resp. .resume 
also got called for those cases?
Ouch :-(

I've added others who've submitted dev_pm_ops patches in CC.

> I'll fix up the floppy and hp-wmi patches.

Note that those are already in mainline, as is pcspkr.

Thanks,
FJP

<Prev in Thread] Current Thread [Next in Thread>