linux-mips
[Top] [All Lists]

Re: [PATCH V2] au1xmmc: dev_pm_ops conversion

To: Frans Pop <elendil@planet.nl>
Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Sat, 25 Jul 2009 12:10:37 -0700
Cc: Manuel Lauss <manuel.lauss@googlemail.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Manuel Lauss <manuel.lauss@gmail.com>, "Rafael J. Wysocki" <rjw@sisk.pl>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=uKDnQ5sP5iShFdZ+0Ls1+D/gKVOdG0XpsThnwGve36U=; b=IpnvxWN8CFBCHvktFtUWUw8tWsIQmSDHxP83zmVhbH8zYaGchCoXja9x7CQfYrQ8Rz Pjnn1sAVJMd36Yte7RWTHqX+5JGLu8+jSeVp90gTOw+AOeokvNgyjeeNO/hmPXnKy4kQ atqiYt9E0qc7Vk67elb9sajYmM5zpNqN/3Tn0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=sOV3PqvkgJPicjheVGWmjoc9l1r6QoE0ibBwK7EeLMmcMZ63xMJbH4WiEmBbIgIXRo G7lYRnKH9YWSCj++48rzuafdJf7zACW+HdxyMjHrf/YSLSaMbI+jgX7cUZHirLeXszcS ZnJnJkknqsfpecDarVF2CKVgSBD0Ep5LclSEM=
In-reply-to: <200907252019.01266.elendil@planet.nl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1248275919-3296-1-git-send-email-manuel.lauss@gmail.com> <20090725174449.GC14062@dtor-d630.eng.vmware.com> <200907252019.01266.elendil@planet.nl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Jul 25, 2009 at 08:18:58PM +0200, Frans Pop wrote:
> On Saturday 25 July 2009, Dmitry Torokhov wrote:
> > On Wed, Jul 22, 2009 at 05:18:39PM +0200, Manuel Lauss wrote:
> > > Cc: Frans Pop <elendil@planet.nl>
> > > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> > >
> > > +
> > > +static struct dev_pm_ops au1xmmc_pmops = {
> > > + .resume         = au1xmmc_resume,
> > > + .suspend        = au1xmmc_suspend,
> > > +};
> > > +
> >
> > Was suspend to disk tested? It requires freeze()/thaw().
> 
> Is that a regression introduced by this patch then? If so, many more of 
> the recent dev_pm_ops conversion patches would need to be revisited.

Yes, as far as I understand they would. Let's ask Rafael to confirm...

-- 
Dmitry

<Prev in Thread] Current Thread [Next in Thread>